Script optimieren

Andman erstellt 25 Apr. 2016 09:56

Hallo!

Hab hier zwei Scripts, die mir etwas Kopfschmerzen bereiten. Sie funktionieren, aber evtl. könnten sie etwas optimiert werden. Im Endeffekt geht es um das Generieren von Worddokumenten, da hängt auch noch mehr dran. Ist aber eine kompliziertere Geschichte. Speziell geht es mir um diese zwei Scripts (Powershell und JavaScript). Vielleicht hat ja jemand Verbesserungsvorschläge, was die Syntax angeht.

Script Nr. 1

$sourceWebURL = "[[=Context.Site.Url]][[=Context.WebUrl]]"
$sourceListName = "SerienbriefeTemp"
$spSourceWeb = Get-SPWeb $sourceWebURL
$spSourceList = $spSourceWeb.Lists[$sourceListName]
$spQuery = New-Object Microsoft.SharePoint.SPQuery
$caml = '<OrderBy><FieldRef Name="Created" Ascending="True"/></OrderBy>'
$spQuery.Query = $caml
$listItems = $spSourceList.getItems($spQuery)
foreach($item in $listItems)
{
   $latestItem = $item
}
$latestItem | ForEach-Object {
    $Kontakte = $_['Kontakte']
    $Author = $_['Author']
    $Title = $_['Title']
}
$Author = $Author.Substring($Author.IndexOf('#') + 1);
$fullName = $author;
$names = $fullName.Split(',')
$FirstName = $names[1].Trim()
$LastName = $names[0]
$author = $FirstName + " " + $LastName
$contactId = @()
$contactId = $Kontakte.LookupId
$contactListName = "Kontakte"
$spContactList = $spSourceWeb.Lists[$contactListName]
$spContactItems = $spContactList.Items
$spContactItems | ForEach-Object {
    foreach ($id in $contactId) {
            if($_['ID'] -eq $id){
               $_['TempName'] = $author
               $_['TempTitle'] = $Title
               $_.Update()             
            }
    } 
}
$spSourceWeb.Dispose()

Script Nr. 2

JavaScript: function modalClosed(result, args) {
        if (result === SP.UI.DialogResult.OK) {

SP.SOD.executeFunc('sp.js', 'SP.ClientContext', createListItem(args));
 }
   }

JavaScript: var options = {
title: "Brief erstellen",
url: '[[=Context.Site.Url]]/crm/contacts/Lists/Serienbriefe/newform.aspx?contactids=' +[[ID]]+'&activityid=6',
dialogReturnValueCallback: modalClosed
        };
SP.UI.ModalDialog.showModalDialog( options );

JavaScript: function createListItem(args) {
   
    var clientContext = new SP.ClientContext.get_current();

    var oList = clientContext.get_web().get_lists().getByTitle('SerienbriefeTemp');
       
    var itemCreateInfo = new SP.ListItemCreationInformation();
    this.oListItem = oList.addItem(itemCreateInfo);
   
    var vorlageLU = new SP.FieldLookupValue();

    vorlageLU.set_lookupId(parseInt(args[1]));
   
    if(args[2])
    {
    var projectLU = new SP.FieldLookupValue();
    projectLU.set_lookupId(parseInt(args[2]));
    oListItem.set_item('Projekt', projectLU);
    }

    oListItem.set_item('Title', args[0]);
    oListItem.set_item('Vorlage', vorlageLU);
   
    oListItem.set_item('Kontakte', [[ID]]);

       
    oListItem.update();

    clientContext.load(oListItem);
       
    clientContext.executeQueryAsync(Function.createDelegate(this, onQuerySucceeded(args)), Function.createDelegate(this, onQueryFailed));
}

JavaScript: function onQuerySucceeded(args) {

    //alert('Item created: ' + oListItem.get_id());
    setTimeout(function(){
    window.open('[[=Context.Site.Url]]/crm/contacts/MailMerge/' + args[0] +' - [[=UPGREAT.SPExtensions.ItemHandling.Folders.FolderHandler.MakeValidFolderName([[=Context.User.Name]])]].docx');
    }, 7000);
}

JavaScript: function onQueryFailed(sender, args) {

    alert('Request failed. ' + args.get_message() + '\n' + args.get_stackTrace());
}